[Top] [All Lists]

Re: [PATCH] xfs: ensure truncate forces zeroed blocks to disk

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: ensure truncate forces zeroed blocks to disk
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 10:10:15 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150223205109.GE13522@xxxxxxxxxxxxx>
References: <1424299725-26067-1-git-send-email-david@xxxxxxxxxxxxx> <20150223205109.GE13522@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 23, 2015 at 12:51:09PM -0800, Christoph Hellwig wrote:
> This looks correct, but is there a good (performance) reason against
> simply unconditionally flushing and waiting?

No idea. All I am concerned about is correctness - getting the
partial block flushed in the case that the on-disk size is the same
as the in-memory size is the fix needed here, otherwise the
behaviour should be unchanged.

Given that I'm not sure what the effect of an unconditional flush is
going to be, I'm not going to mix such a change with an otherwise
obvious data corruption fix that we need to backport to other
kernels.  If you have the time to determine there is no performance
impact from an unconditional flush, then I'll happily take the
change. ;)


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>