xfs
[Top] [All Lists]

[PATCH 2/2] xfs: clarify async write failure ratelimit message

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH 2/2] xfs: clarify async write failure ratelimit message
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 23 Feb 2015 13:19:11 -0600
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54EB7BDB.7080202@xxxxxxxxxx>
References: <54EB7BDB.7080202@xxxxxxxxxx>
Today, when the "failing async writes" get ratelimited, we see:

XFS:: 62836 callbacks suppressed

Aside from the extra ":" it's not entirely clear which message is being
suppressed, especially if other messages or ratelimits are happening
at the same time.  Clarify this as i.e.:

XFS (dm-11): Failing async write on buffer block 0x140090. Retrying async write.
XFS: Failing async write: 62836 callbacks suppressed

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

I ... don't *think* this is abuse of __ratelimit(), is it?

diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
index 4751c5f..08f315d 100644
--- a/fs/xfs/xfs_buf_item.c
+++ b/fs/xfs/xfs_buf_item.c
@@ -537,9 +537,9 @@ xfs_buf_item_push(
 
        /* has a previous flush failed due to IO errors? */
        if ((bp->b_flags & XBF_WRITE_FAIL) &&
-           ___ratelimit(&xfs_buf_write_fail_rl_state, "XFS:")) {
+           ___ratelimit(&xfs_buf_write_fail_rl_state, "XFS: Failing async 
write")) {
                xfs_warn(bp->b_target->bt_mount,
-"Detected failing async write on buffer block 0x%llx. Retrying async write.",
+"Failing async write on buffer block 0x%llx. Retrying async write.",
                         (long long)bp->b_bn);
        }
 

<Prev in Thread] Current Thread [Next in Thread>