xfs
[Top] [All Lists]

Re: [PATCH] xfs: Introduce permanent async buffer write IO failures

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Introduce permanent async buffer write IO failures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 20 Feb 2015 10:02:29 +1100
Cc: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54E65878.2000302@xxxxxxxxxxx>
References: <1424298740-25821-1-git-send-email-david@xxxxxxxxxxxxx> <20150219142842.GA2291@xxxxxxxxxxxxxx> <54E65878.2000302@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 19, 2015 at 03:41:12PM -0600, Eric Sandeen wrote:
> On 2/19/15 8:28 AM, Brian Foster wrote:
> > On Thu, Feb 19, 2015 at 09:32:20AM +1100, Dave Chinner wrote:
> 
> ...
> 
> >> +  if (!(bp->b_flags & (XBF_STALE|XBF_WRITE_FAIL))) {
> >> +          bp->b_flags |= XBF_WRITE | XBF_ASYNC |
> >> +                         XBF_DONE | XBF_WRITE_FAIL;
> >> +          xfs_buf_submit(bp);
> >> +          return true;
> 
> so, shouldn't
> 
>               xfs_buf_ioerror(bp, 0);
> 
> go under this conditional to address Brian's point... ok, you just responded 
> to that. :)
> 
> FWIW, this is re-setting XBF_ASYNC which must already be set, right?

To be sure, to be sure.... ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>