xfs
[Top] [All Lists]

Re: [PATCH] xfs: Introduce permanent async buffer write IO failures

To: Brian Foster <bfoster@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: Introduce permanent async buffer write IO failures
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 19 Feb 2015 15:41:12 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150219142842.GA2291@xxxxxxxxxxxxxx>
References: <1424298740-25821-1-git-send-email-david@xxxxxxxxxxxxx> <20150219142842.GA2291@xxxxxxxxxxxxxx>
On 2/19/15 8:28 AM, Brian Foster wrote:
> On Thu, Feb 19, 2015 at 09:32:20AM +1100, Dave Chinner wrote:

...

>> +    if (!(bp->b_flags & (XBF_STALE|XBF_WRITE_FAIL))) {
>> +            bp->b_flags |= XBF_WRITE | XBF_ASYNC |
>> +                           XBF_DONE | XBF_WRITE_FAIL;
>> +            xfs_buf_submit(bp);
>> +            return true;

so, shouldn't

                xfs_buf_ioerror(bp, 0);

go under this conditional to address Brian's point... ok, you just responded to 
that. :)

FWIW, this is re-setting XBF_ASYNC which must already be set, right?
 
-Eric

<Prev in Thread] Current Thread [Next in Thread>