xfs
[Top] [All Lists]

Re: [Cluster-devel] [PATCH 6/8] quota: Make ->set_info use structure wit

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [Cluster-devel] [PATCH 6/8] quota: Make ->set_info use structure with neccesary info to VFS and XFS
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 18 Feb 2015 18:17:58 +0100
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150218165334.GB29465@xxxxxxxxxxxxx>
References: <1424267274-11836-1-git-send-email-jack@xxxxxxx> <1424267274-11836-7-git-send-email-jack@xxxxxxx> <20150218165334.GB29465@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed 18-02-15 08:53:34, Christoph Hellwig wrote:
> On Wed, Feb 18, 2015 at 02:47:52PM +0100, Jan Kara wrote:
> > Change ->set_info to take new qc_info structure which contains all the
> > necessary information both for XFS and VFS. Convert Q_SETINFO handler
> > to use this structure.
...
> > +/* Structure for communicating via ->set_info */
> > +struct qc_info {
> > +   int i_fieldmask;        /* mask of fields to change in ->set_info() */
> > +   unsigned int i_flags;           /* Flags QCI_* */
> > +   unsigned int i_spc_timelimit;   /* Time after which space softlimit is
> > +                                    * enforced */
> > +   unsigned int i_ino_timelimit;   /* Ditto for inode softlimit */
> > +   unsigned int i_rt_spc_timelimit;/* Ditto for real-time space */
> > +   unsigned int i_spc_warnlimit;   /* Limit for number of space warnings */
> > +   unsigned int i_ino_warnlimit;   /* Limit for number of inode warnings */
> > +   unsigned int i_rt_spc_warnlimit;        /* Ditto for real-time space */
> > +};
> 
> What does the i_ prefix stand for?
  It stands for info. I can change it e.g. to qci_ for quotactl info if you
think that would be better...

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>