xfs
[Top] [All Lists]

Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callba

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callback
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 18 Feb 2015 18:11:38 +0100
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150218165154.GA29465@xxxxxxxxxxxxx>
References: <1424267274-11836-1-git-send-email-jack@xxxxxxx> <1424267274-11836-4-git-send-email-jack@xxxxxxx> <20150218165154.GA29465@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed 18-02-15 08:51:54, Christoph Hellwig wrote:
> > +static void
> > +xfs_qm_fill_state(
> > +   struct qc_type_state *tstate,
> > +   struct xfs_mount *mp,
> > +   struct xfs_inode *ip,
> > +   xfs_ino_t ino)
> 
> > +/*
> > + * Return quota status information, such as enforcements, quota file inode
> > + * numbers etc.
> > + */
> > +static int
> > +xfs_fs_get_quota_state(
> > +   struct super_block *sb,
> > +   struct qc_state *state)
> 
> We usually tab-align the arguments in XFS prototypes.
  OK, fixed.

> Otherwise this patch looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
  Thanks.

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>