| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callback |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Wed, 18 Feb 2015 18:11:38 +0100 |
| Cc: | Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150218165154.GA29465@xxxxxxxxxxxxx> |
| References: | <1424267274-11836-1-git-send-email-jack@xxxxxxx> <1424267274-11836-4-git-send-email-jack@xxxxxxx> <20150218165154.GA29465@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed 18-02-15 08:51:54, Christoph Hellwig wrote:
> > +static void
> > +xfs_qm_fill_state(
> > + struct qc_type_state *tstate,
> > + struct xfs_mount *mp,
> > + struct xfs_inode *ip,
> > + xfs_ino_t ino)
>
> > +/*
> > + * Return quota status information, such as enforcements, quota file inode
> > + * numbers etc.
> > + */
> > +static int
> > +xfs_fs_get_quota_state(
> > + struct super_block *sb,
> > + struct qc_state *state)
>
> We usually tab-align the arguments in XFS prototypes.
OK, fixed.
> Otherwise this patch looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Cluster-devel] [PATCH 8/8] quota: Hook up Q_XSETQLIM for id 0 to ->set_info, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [Cluster-devel] [PATCH 6/8] quota: Make ->set_info use structure with neccesary info to VFS and XFS, Jan Kara |
| Previous by Thread: | Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callback, Christoph Hellwig |
| Next by Thread: | [PATCH 7/8] xfs: Add support for Q_SETINFO, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |