xfs
[Top] [All Lists]

Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callba

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state callback
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 18 Feb 2015 08:51:54 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1424267274-11836-4-git-send-email-jack@xxxxxxx>
References: <1424267274-11836-1-git-send-email-jack@xxxxxxx> <1424267274-11836-4-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> +static void
> +xfs_qm_fill_state(
> +     struct qc_type_state *tstate,
> +     struct xfs_mount *mp,
> +     struct xfs_inode *ip,
> +     xfs_ino_t ino)

> +/*
> + * Return quota status information, such as enforcements, quota file inode
> + * numbers etc.
> + */
> +static int
> +xfs_fs_get_quota_state(
> +     struct super_block *sb,
> +     struct qc_state *state)

We usually tab-align the arguments in XFS prototypes.


Otherwise this patch looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>