xfs
[Top] [All Lists]

Re: [PATCH] xfs: xfs_alloc_fix_minleft can underflow near ENOSPC

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: xfs_alloc_fix_minleft can underflow near ENOSPC
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Wed, 18 Feb 2015 10:32:27 -0500
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lO/lY9pZInDoUD8jUZDiExk+mNsqmgcIZ16l3h8TynY=; b=FhQq7hxFOy532RUXex76ob7L2yAELhwjcIoDgvVZgF14C0gIrk7bQCjjB0YpxnTBpQ gtWxYr3SiCtKJshoNLMuR+SQ831hC50xmXkb6P66Omm7zi3KodGz+7q6q2ZOTb7IZUeh MD4QnDj/n7K+joSzBvN5BLU+PWAbYQU8nij0Gd5b1Y9RRiyuCV3y8VK1Wkd6V3XKMut6 ke0fobbt/G1oJZimD2fj83rhDrdiVUyE4dwhTo/mgpQttUw8hw0yLE7EN8rJQAWNydfD Dy6GfiAbJ8R1TZ3MlCuH6EzLzQS5AIqL2ez+74mxhMTOEi0YFFQsc2+dkAh2dqiHK8O7 /zZw==
In-reply-to: <20150218004838.GM4251@dastard>
References: <1423782857-11800-1-git-send-email-david@xxxxxxxxxxxxx> <54DE8B6D.8010401@xxxxxxx> <20150214232951.GW4251@dastard> <54E16667.1050200@xxxxxxxxx> <54E22A76.40106@xxxxxxx> <20150216231716.GB4251@dastard> <54E36016.20908@xxxxxxxxx> <20150218004838.GM4251@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 02/17/15 19:48, Dave Chinner wrote:
> On Tue, Feb 17, 2015 at 10:36:54AM -0500, Michael L. Semon wrote:
>> On 02/16/15 18:17, Dave Chinner wrote:
>>> On Mon, Feb 16, 2015 at 11:35:50AM -0600, Mark Tinguely wrote:
>>>> Thanks Michael, you don't need to hold your test box for me. I do
>>>> have a way to recreate these ABBA AGF buffer allocation deadlocks
>>>> and understand the whys and hows very well. I don't have a community
>>>> way to make a xfstest for it but I think your test is getting close.
>>>
>>> If you know what is causing them, then please explain how it occurs
>>> and how you think it needs to be fixed. Just telling us that you know
>>> something that we don't doesn't help us solve the problem. :(
>>>
>>> In general, the use of the args->firstblock is supposed to avoid the
>>> ABBA locking order issues with multiple allocations in the one
>>> transaction by preventing AG selection loops from looping back into
>>> AGs with a lower index than the first allocation that was made.
>>>
>>> So if you are seeing deadlocks, then it may be that we aren't
>>> following this constraint correctly in all locations....
>>
>> Will this be a classic deadlock that will cause problems when trying to
>> kill processes and unmount filesystems?  If so, then I was unable to use
>> generic/224 to trigger a deadlock.  If not, then I'll need a better way
>> of looking at the problem.
> 
> Yes, it will hang the filesystem.
> 
> Cheers,
> 
> Dave.

Thanks.  I'll try again tonight.

Last night's attempt was a combination of fio, fsstress, and a shell loop 
of xfs_io's fcollapse command, all at once on an SSD.  At the end of the 
night, XFS was laughing at me.  Therefore, I added the same test on the 
3-partition RAID-0 side.  This morning, XFS is still laughing at me, but 
the RAID-0 test is still running.

Thanks!

Michael

<Prev in Thread] Current Thread [Next in Thread>