| To: | Namjae Jeon <linkinjeon@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH RESEND 3/12] ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 17 Feb 2015 12:02:20 +1100 |
| Cc: | tytso@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, a.sangwan@xxxxxxxxxxx, bfoster@xxxxxxxxxx, mtk.manpages@xxxxxxxxx, linux-man@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1424101680-3301-4-git-send-email-linkinjeon@xxxxxxxxx> |
| References: | <1424101680-3301-1-git-send-email-linkinjeon@xxxxxxxxx> <1424101680-3301-4-git-send-email-linkinjeon@xxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 17, 2015 at 12:47:50AM +0900, Namjae Jeon wrote: > From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx> > > This patch implements fallocate's FALLOC_FL_INSERT_RANGE for Ext4. > > 1) Make sure that both offset and len are block size aligned. > 2) Update the i_size of inode by len bytes. > 3) Compute the file's logical block number against offset. If the computed > block number is not the starting block of the extent, split the extent > such that the block number is the starting block of the extent. > 4) Shift all the extents which are lying bewteen [offset, last allocated > extent] > towards right by len bytes. This step will make a hole of len bytes > at offset. > > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx> > Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx> I'll leave this for the ext4 folk to review. If I don't get a review by the time we're ready to merge the VFS and XFS code, then I'll leave it out and let Ted merge it inhis own time. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH RESEND 11/12] xfstests: fsx: Add fallocate insert range operation, Dave Chinner |
|---|---|
| Next by Date: | Re: xfs_logprint segfault with external log, Dave Chinner |
| Previous by Thread: | [PATCH RESEND 3/12] ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate, Namjae Jeon |
| Next by Thread: | [PATCH RESEND 4/12] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE, Namjae Jeon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |