xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfsprogs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_s

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 4/4] xfsprogs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spaceman
From: Dhruvesh Rathore <adrscube@xxxxxxxxx>
Date: Wed, 11 Feb 2015 21:52:17 +0530
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=m67bJJT3lSICy4kpkmXowpjdx5GioAJ23EnHFA/omEk=; b=bpnFMTD0RPghERXJjVEsrx5e5vh783N1AxQRBtO5Yvsa5LVyOw/vdNFLlOvQ1myZfE Ia4w91McJKIFqqRjJSSFG/qspB+p8YWh9HgX+XqHJg+t/95HDbZQvKtkHfUofF9t6bQG 80h/rLwmRyFIMJe1Cv1u4dYOWL/zYO1hAmA/kBwYHOlCRZXFQVNYZ9Yu0MdUC+69qIHO G0Od3aWbhnDbvoBrIvuFQubRG1cn6ObRIU8htLAb0thwOgMU4mX/e5J+YOFoO86krhrp wY1OR9Uk5kedZWLloPn5z0O686rk0xKTOEViPgPrY2Q0RulnTgp8LLGLrn/Q94uUEWXG x5+Q==
In-reply-to: <20150210221914.GQ4251@dastard>
References: <54ca361b.6841460a.02cf.3cca@xxxxxxxxxxxxx> <20150210221914.GQ4251@dastard>
On Wed, Feb 11, 2015 at 3:49 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Thu, Jan 29, 2015 at 07:01:02PM +0530, Dhruvesh Rathore wrote:
>>
>> This patch is concerned with the changes to be done in userspace code for
>> turning FS_IOC_FIEMAPFS present in the earlier version of xfs_spaceman
>> into an XFS specific ioctl called XFS_IOC_FIEMAPFS, which uses all existing
>> fiemap insfrastructure.
>> By introducing XFS_IOC_FIMEAPFS ioctl, it can be seperated from file based
>> fiemap commands and allows us to review it and push it as we need, making the
>> process much simpler.
> .....
>>  typedef struct histent
>> @@ -201,9 +201,9 @@
>>               fiemap->fm_length = length;
>>               fiemap->fm_extent_count = NR_EXTENTS;
>>
>> -             ret = ioctl(file->fd, FS_IOC_FIEMAPFS, (unsigned long)fiemap);
>> +             ret = xfsctl(file->name,file->fd, XFS_IOC_FIEMAPFS, (unsigned 
>> long)fiemap);
>>               if (ret < 0) {
>   ^
> Patch hunk is corrupt: it is missing the leading whitespace to
> indicate "no change on this line".
>
> I've fixed it up to apply the patch.
>
> -Dave.

We again apologize for the constant white space errors. We will surely make
use of the various git commands that you have mentioned to ensure that we
send clean patches.
Thank you for reworking and applying the patches :)

Regards,
A-DRS

<Prev in Thread] Current Thread [Next in Thread>