xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spacem

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 3/4] xfs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spaceman
From: Dhruvesh Rathore <adrscube@xxxxxxxxx>
Date: Wed, 11 Feb 2015 21:49:29 +0530
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=VgB7f4Ip8AZ3NGmtoPGNWRgYzB0ymgRvm/OllaXxc2E=; b=VwAsJKpNPLz0qv2h5ry57PAnIrk5NHi9ECM88oS/cxKRgzDAB6zpAfzac+1S4Mb+8I uAwMPPgzuUIFQ/6zUKrsDBGegusomy6+CN6fodNtVmmRGthT1CXrtqhEEiuoL5u5lXLV ULp5W2ctKyNLsmfUoUwaFdZxm8vGtuj4SBk9JIL1RH4M/c3N7z2oToiwFrWPql+sj0qv 2aKnCH6epM4tUZqq1iy4BJMgyuY7w+avfg2BFTYxPZupzmBxxyfUCztgbxc9fcZdcps5 jQosHrrVNqGdXFmg2R4YvQJQhbPAGp7+O7hG/TaYX3RJ4iUVnaQ4k6opbUDEQFObJM+D 71Yw==
In-reply-to: <20150210101752.GB12722@dastard>
References: <54ca35b7.2786440a.6990.450d@xxxxxxxxxxxxx> <20150210101752.GB12722@dastard>
On Tue, Feb 10, 2015 at 3:47 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Thu, Jan 29, 2015 at 06:59:22PM +0530, Dhruvesh Rathore wrote:
>>
>> This patch is concerned with the changes to be done in kernel space code for
>> turning FS_IOC_FIEMAPFS present in the earlier version of xfs_spaceman
>> into an XFS specific ioctl called XFS_IOC_FIEMAPFS, which uses all existing
>> fiemap insfrastructure.
>> By introducing XFS_IOC_FIMEAPFS ioctl, it can be seperated from file based
>> fiemap commands and allows us to review it and push it as we need, making the
>> process much simpler.
>>
>> ----------------------------------------------------------------------------------------
>>
>> Signed-off-by: Dhruvesh Rathore <dhruvesh_r@xxxxxxxxxxx>
>> Signed-off-by: Amey Ruikar <ameyruikar@xxxxxxxxx>
>> Signed-off-by: Somdeep Dey <somdeepdey10@xxxxxxxxx>
>> ---
>> fs/ioctl.c            | 3  ++-
>> include/linux/fs.h    | 6  ++++++
>> fs/xfs/xfs_ioctl.c    | 55 +++++++++++++
>> fs/xfs/xfs_fs.h               | 1  +
>> 4 files changed, 64 insertions(+), 1 deletion(-)
>
> Ok, so this patch doesn't remove any of the now unused
> functionality I added to support the VFS based ioctl.
>
> What I'm going to do with this is combine it with the initial
> "introduce FS_IOC_FIEMAP" patch I wrote (including all it's
> documentation!) as the first patch of the kernel side patch series
> to introduced XFS_IOC_FIEMAPFS.
>

Seems appropriate to us.

Regards,
A-DRS

<Prev in Thread] Current Thread [Next in Thread>