xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfsprogs: Addition in debug option -d of xfs_spaceman

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 2/4] xfsprogs: Addition in debug option -d of xfs_spaceman
From: Dhruvesh Rathore <adrscube@xxxxxxxxx>
Date: Wed, 11 Feb 2015 21:47:09 +0530
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1Pv3E4jWNiErfncZKd/ZP4tc5kjekEoOn1hXuFrAexU=; b=SlIf1+EJHGok4FQai1fjAYxR92i6g6r1uhgB1cJgWU/nWmaL7pZSrs557NOb6o6tLm 2YeGD3zTXSvpa19yeldqjSnojEXfy9P89IJrafsbp4FZC0B1GWljKjXkyQE1tZNEWfQj GiRikQXV7oOQ896TG339JwUI5uqMHt/RscZ1kOfCZIyn1sm2m+qw32xb3I1h/OkG8crO ktj4Wot+8VSYWnsmYebq+xRzaHL59NNgzy3WSm/31Nr7nRpssAsnotLLjSko+0NnYyh1 xNwBTOGFrtjAzghodkzs9u+BbF9WombPr6sErxjvYK5/pup4P8zkFRdii3oyxnUgl6Uu 8bMw==
In-reply-to: <20150210221421.GP4251@dastard>
References: <54ca34c6.4696420a.0f32.4513@xxxxxxxxxxxxx> <20150210221421.GP4251@dastard>
On Wed, Feb 11, 2015 at 3:44 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Thu, Jan 29, 2015 at 06:55:21PM +0530, Dhruvesh Rathore wrote:
>>
>> The xfs_spaceman utility did not have a a proper title to the content
>> displayed using -d (debug) option.
> .....
>>
>> @@ -332,20 +332,23 @@
>>  static int
>>  freesp_f(
>>       int             argc,
>>       char            **argv)
>>  {
>>       xfs_agnumber_t  agno;
>>
>>       if (!init(argc, argv))
>>               return 0;
>>
>> +     if (dumpflag)
>> +             printf("%8s %8s %8s\n", "agno", "agbno", "len");
>> +
>>       for (agno = 0; agno < file->geom.agcount; agno++)  {
>>               if (inaglist(agno))
>>                       scan_ag(agno);
>>       }
>>       if (histcount)
>>               printhist();
>
> Patch does not apply to the current tree. It's got stray whitespace
> and lines in it that are in the original source file.
>
> I've fixed this up for the moment, but please make sure your
> patches apply to a clean tree.
>

We apologize for the constant stray white space errors and will
make sure to make clean patches from now on.
Thank you for reworking and applying the patch to the current tree :)

Regards,
A-DRS

<Prev in Thread] Current Thread [Next in Thread>