xfs
[Top] [All Lists]

Re: shared/032 is broken on Fedora

To: Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Subject: Re: shared/032 is broken on Fedora
From: Boaz Harrosh <boaz@xxxxxxxxxxxxx>
Date: Wed, 11 Feb 2015 15:10:44 +0200
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54DB35F0.1010203@xxxxxxxxxxxxx>
References: <54DB35F0.1010203@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 02/11/2015 12:58 PM, Boaz Harrosh wrote:
> 
> This is not the proper patch just to show a working version for Fedora. But I 
> think
> it now breaks the other ARCHs.
> 
> What happens is that the output of ${MKFS_PROG}.* is:
>       /usr/sbin/mkfs.bfs /usr/sbin/mkfs.btrfs /usr/sbin/mkfs.cramfs 
> /usr/sbin/mkfs.ext2 /usr/sbin/mkfs.ext3 /usr/sbin/mkfs.ext4 ...
> 
> So in Fedora sbin has moved to /usr/... and therefor the sed below fails.
> My sed foo is not good enough. How to support both places for sbin?
> 
> Also why the "_supported_fs xfs btrfs"? So if all those other mkfs.* that are 
> destructive to
> foreign filesystem, should the test not fail instead of skipped?
> Maybe if the maintainers of all these filesystems day in and day out running 
> xfstests and
> see shared/032 failing, they might decide to fix their evil ways. Instead of 
> skipping the
> test and the said maintainer just ignores it?
> 

I was thinking about fixing this test, say for ext4. And came to the conclusion.

Should I not hack and fix the mount command? This problem is common to all
filesystems. Why do we want to force all mkfs.* maintainers to link with some
global library that checks all registered FSs and see existence of an FS, 
something
like blkid.

Why not link that library to the driver "mount" command, and not call the
mkfs.$type in question at all unless say --force flag is supplied.

This way I fix this test for all FSs past and future.
(Should I send a patch?)

Thanks
Boaz

<Prev in Thread] Current Thread [Next in Thread>