xfs
[Top] [All Lists]

shared/032 is broken on Fedora

To: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Subject: shared/032 is broken on Fedora
From: Boaz Harrosh <boaz@xxxxxxxxxxxxx>
Date: Wed, 11 Feb 2015 12:58:56 +0200
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
This is not the proper patch just to show a working version for Fedora. But I 
think
it now breaks the other ARCHs.

What happens is that the output of ${MKFS_PROG}.* is:
        /usr/sbin/mkfs.bfs /usr/sbin/mkfs.btrfs /usr/sbin/mkfs.cramfs 
/usr/sbin/mkfs.ext2 /usr/sbin/mkfs.ext3 /usr/sbin/mkfs.ext4 ...

So in Fedora sbin has moved to /usr/... and therefor the sed below fails.
My sed foo is not good enough. How to support both places for sbin?

Also why the "_supported_fs xfs btrfs"? So if all those other mkfs.* that are 
destructive to
foreign filesystem, should the test not fail instead of skipped?
Maybe if the maintainers of all these filesystems day in and day out running 
xfstests and
see shared/032 failing, they might decide to fix their evil ways. Instead of 
skipping the
test and the said maintainer just ignores it?

Thanks
Boaz

---
diff --git a/tests/shared/032 b/tests/shared/032
index a410003..726e6b4 100755
--- a/tests/shared/032
+++ b/tests/shared/032
@@ -37,8 +37,8 @@ rm -f $seqres.full
 . ./common/filter
 
 # real QA test starts here
-_supported_fs xfs btrfs
+# _supported_fs xfs btrfs
 _supported_os Linux
 
 _require_scratch_nocheck
 _require_no_large_scratch_dev
@@ -49,8 +49,7 @@ if [ "$FSTYP" == "btrfs" ]; then
                _notrun "Installed mkfs.btrfs does not support -f option"
 fi
 
-echo "Silence is golden."
-for fs in `echo ${MKFS_PROG}.* | sed -e 's/.sbin.mkfs.//g'`
+for fs in `echo ${MKFS_PROG}.* | sed -e 's/.usr\/sbin.mkfs.//g'`
 do
        preop=""        # for special input needs
        preargs=""      # for any special pre-device options

<Prev in Thread] Current Thread [Next in Thread>