[Top] [All Lists]

Re: [PATCH 4/4] xfsprogs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_s

To: Dhruvesh Rathore <adrscube@xxxxxxxxx>
Subject: Re: [PATCH 4/4] xfsprogs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spaceman
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 11 Feb 2015 09:19:14 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54ca361b.6841460a.02cf.3cca@xxxxxxxxxxxxx>
References: <54ca361b.6841460a.02cf.3cca@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 29, 2015 at 07:01:02PM +0530, Dhruvesh Rathore wrote:
> This patch is concerned with the changes to be done in userspace code for
> turning FS_IOC_FIEMAPFS present in the earlier version of xfs_spaceman 
> into an XFS specific ioctl called XFS_IOC_FIEMAPFS, which uses all existing
> fiemap insfrastructure.
> By introducing XFS_IOC_FIMEAPFS ioctl, it can be seperated from file based
> fiemap commands and allows us to review it and push it as we need, making the
> process much simpler.
>  typedef struct histent
> @@ -201,9 +201,9 @@
>               fiemap->fm_length = length;
>               fiemap->fm_extent_count = NR_EXTENTS;
> -             ret = ioctl(file->fd, FS_IOC_FIEMAPFS, (unsigned long)fiemap);
> +             ret = xfsctl(file->name,file->fd, XFS_IOC_FIEMAPFS, (unsigned 
> long)fiemap);
>               if (ret < 0) {
Patch hunk is corrupt: it is missing the leading whitespace to
indicate "no change on this line".

I've fixed it up to apply the patch.

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>