[Top] [All Lists]

Re: [PATCH 3/4] xfs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spacem

To: Dhruvesh Rathore <adrscube@xxxxxxxxx>
Subject: Re: [PATCH 3/4] xfs: Adding XFS_IOC_FIEMAPFS ioctl for use in xfs_spaceman
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 10 Feb 2015 21:17:52 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54ca35b7.2786440a.6990.450d@xxxxxxxxxxxxx>
References: <54ca35b7.2786440a.6990.450d@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 29, 2015 at 06:59:22PM +0530, Dhruvesh Rathore wrote:
> This patch is concerned with the changes to be done in kernel space code for
> turning FS_IOC_FIEMAPFS present in the earlier version of xfs_spaceman 
> into an XFS specific ioctl called XFS_IOC_FIEMAPFS, which uses all existing
> fiemap insfrastructure.
> By introducing XFS_IOC_FIMEAPFS ioctl, it can be seperated from file based
> fiemap commands and allows us to review it and push it as we need, making the
> process much simpler.
> ----------------------------------------------------------------------------------------
> Signed-off-by: Dhruvesh Rathore <dhruvesh_r@xxxxxxxxxxx>
> Signed-off-by: Amey Ruikar <ameyruikar@xxxxxxxxx>
> Signed-off-by: Somdeep Dey <somdeepdey10@xxxxxxxxx>
> ---
> fs/ioctl.c            | 3  ++-
> include/linux/fs.h    | 6  ++++++
> fs/xfs/xfs_ioctl.c    | 55 +++++++++++++
> fs/xfs/xfs_fs.h               | 1  +
> 4 files changed, 64 insertions(+), 1 deletion(-) 

Ok, so this patch doesn't remove any of the now unused
functionality I added to support the VFS based ioctl.

What I'm going to do with this is combine it with the initial
"introduce FS_IOC_FIEMAP" patch I wrote (including all it's
documentation!) as the first patch of the kernel side patch series
to introduced XFS_IOC_FIEMAPFS.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>