xfs
[Top] [All Lists]

Re: [PATCH 0/2] xfs: pass mp to XFS_WANT_CORRUPTED_*

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 0/2] xfs: pass mp to XFS_WANT_CORRUPTED_*
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Tue, 10 Feb 2015 08:06:47 -0200
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54D94A2A.8020906@xxxxxxxxxxx>
Mail-followup-to: Eric Sandeen <sandeen@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
References: <54D53E8C.8070207@xxxxxxxxxx> <20150208213502.GA4251@dastard> <20150209130926.GA18336@xxxxxxxxxxxxxx> <20150209211744.GT12722@dastard> <20150209214359.GN18336@xxxxxxxxxxxxxx> <20150209215827.GW12722@dastard> <54D94A2A.8020906@xxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Feb 09, 2015 at 06:00:42PM -0600, Eric Sandeen wrote:
> On 2/9/15 3:58 PM, Dave Chinner wrote:
> > On Mon, Feb 09, 2015 at 04:43:59PM -0500, Brian Foster wrote:
> >> On Tue, Feb 10, 2015 at 08:17:44AM +1100, Dave Chinner wrote:
> 
> ...
> 
> >> Sure, but ASSERT_CORRUPT_RET() is the same length as the example above.
> >> ASSERT_CORRUPT_GOTO() is only a few chars longer than the associated
> >> example. We could still use WANT over ASSERT I suppose to shorten it up
> >> further. Either of those are at least still self-explanatory in my
> >> opinion.
> > 
> > Thinking on it a bit further, the XFS_WANT_CORRUPTED macros have an
> > internal ASSERT in them, so they are effectively an ASSERT
> > statement. I could live with those names, especially as ASSERT is
> > something that can be compiled into production kernels via
> > CONFIG_XFS_WARN=y to turn them into error messages...
> 
> Sooooo you all want "ASSERT_CORRUPTED_RET / ASSERT_CORRUPTED_GOTO" ?
> 
> In a light mauve? ;)
> 

I could live with that, better a relative big macro's name than a shorter
abbreviated one that you should buy a crystal ball to really understand what it
means :)

> -Eric
> 
> > Cheers,
> > 
> > Dave.
> > 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>