xfs
[Top] [All Lists]

[PATCH] xfs: remove old and redundant comment in xfs_mount_validate_sb

To: david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: remove old and redundant comment in xfs_mount_validate_sb
From: Wang Sheng-Hui <shhuiw@xxxxxxxxxxx>
Date: Mon, 9 Feb 2015 09:00:16 +0800
Delivered-to: xfs@xxxxxxxxxxx
Per Dave,
The error messages document the reason for the checks better than the comment
and the comments about volume mounts date back to Irix and so aren't relevant
any more. So just remove the old and redundant comment.

Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxxxx>
---
 fs/xfs/libxfs/xfs_sb.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index 752915f..b231c59 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -174,14 +174,6 @@ xfs_mount_validate_sb(
        bool            check_inprogress,
        bool            check_version)
 {
-
-       /*
-        * If the log device and data device have the
-        * same device number, the log is internal.
-        * Consequently, the sb_logstart should be non-zero.  If
-        * we have a zero sb_logstart in this case, we may be trying to mount
-        * a volume filesystem in a non-volume manner.
-        */
        if (sbp->sb_magicnum != XFS_SB_MAGIC) {
                xfs_warn(mp, "bad magic number");
                return -EWRONGFS;
-- 
2.1.2




<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: remove old and redundant comment in xfs_mount_validate_sb, Wang Sheng-Hui <=