xfs
[Top] [All Lists]

Re: [PATCH v3 12/18] xfs: filter out sparse regions from individual inod

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v3 12/18] xfs: filter out sparse regions from individual inode allocation
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 9 Feb 2015 09:49:42 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1423252385-3063-13-git-send-email-bfoster@xxxxxxxxxx>
References: <1423252385-3063-1-git-send-email-bfoster@xxxxxxxxxx> <1423252385-3063-13-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 06, 2015 at 02:52:59PM -0500, Brian Foster wrote:
> Inode allocation from an existing record with free inodes traditionally
> selects the first inode available according to the ir_free mask. With
> sparse inode chunks, the ir_free mask could refer to an unallocated
> region. We must mask the unallocated regions out of ir_free before using
> it to select a free inode in the chunk.
> 
> Create the xfs_inobt_first_free_inode() helper to find the first free
> inode available of the allocated regions of the inode chunk.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Helper can go early on in the patch set, and then when the sparse
inode support is added the bitmap stuff can added to the helepr.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>