xfs
[Top] [All Lists]

Re: [PATCH v3 01/18] xfs: add sparse inode chunk alignment superblock fi

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v3 01/18] xfs: add sparse inode chunk alignment superblock field
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 7 Feb 2015 09:40:47 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1423252385-3063-2-git-send-email-bfoster@xxxxxxxxxx>
References: <1423252385-3063-1-git-send-email-bfoster@xxxxxxxxxx> <1423252385-3063-2-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 06, 2015 at 02:52:48PM -0500, Brian Foster wrote:
> Add sb_spinoalignmt to the superblock to specify sparse inode chunk
> alignment. This also currently represents the minimum allowable sparse
> chunk allocation size.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_format.h | 6 +++---
>  fs/xfs/libxfs/xfs_sb.c     | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> index 8eb7189..051c24d 100644
> --- a/fs/xfs/libxfs/xfs_format.h
> +++ b/fs/xfs/libxfs/xfs_format.h
> @@ -170,7 +170,7 @@ typedef struct xfs_sb {
>       __uint32_t      sb_features_log_incompat;
>  
>       __uint32_t      sb_crc;         /* superblock crc */
> -     __uint32_t      sb_pad;
> +     xfs_extlen_t    sb_spinoalignmt;/* sparse inode chunk alignment */

That's a mounthful. sb_spino_align is a bit easier to read, IMO.

> @@ -282,7 +282,7 @@ typedef enum {
>       XFS_SBS_LOGSECTLOG, XFS_SBS_LOGSECTSIZE, XFS_SBS_LOGSUNIT,
>       XFS_SBS_FEATURES2, XFS_SBS_BAD_FEATURES2, XFS_SBS_FEATURES_COMPAT,
>       XFS_SBS_FEATURES_RO_COMPAT, XFS_SBS_FEATURES_INCOMPAT,
> -     XFS_SBS_FEATURES_LOG_INCOMPAT, XFS_SBS_CRC, XFS_SBS_PAD,
> +     XFS_SBS_FEATURES_LOG_INCOMPAT, XFS_SBS_CRC, XFS_SBS_SPINOALIGNMT,
>       XFS_SBS_PQUOTINO, XFS_SBS_LSN,
>       XFS_SBS_FIELDCOUNT
>  } xfs_sb_field_t;

These are gone in the for-next tree.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>