xfs
[Top] [All Lists]

Re: [PATCH] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_R

To: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprog: xfsio: update xfs_io manpage for FALLOC_FL_INSERT_RANGE
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 7 Feb 2015 09:22:27 +1100
Cc: 'Eric Sandeen' <sandeen@xxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, 'Ashish Sangwan' <a.sangwan@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <002401d041cf$570eae40$052c0ac0$@samsung.com>
References: <001f01d041cb$39fbbc70$adf33550$@samsung.com> <54D45068.2030209@xxxxxxxxxxx> <002401d041cf$570eae40$052c0ac0$@samsung.com>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Feb 06, 2015 at 02:39:56PM +0900, Namjae Jeon wrote:
> > On 2/5/15 11:10 PM, Namjae Jeon wrote:
> > > Update xfs_io manpage for FALLOC_FL_INSERT_RANGE.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > > Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
> > > ---
> > >  man/man8/xfs_io.8 | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> > > index cf27b99..416206f 100644
> > > --- a/man/man8/xfs_io.8
> > > +++ b/man/man8/xfs_io.8
> > > @@ -404,6 +404,11 @@ Call fallocate with FALLOC_FL_COLLAPSE_RANGE flag as 
> > > described in the
> > >  manual page to de-allocates blocks and eliminates the hole created in 
> > > this process
> > >  by shifting data blocks into the hole.
> > >  .TP
> > > +.BI finsert " offset length"
> > > +Call fallocate with FALLOC_FL_INSERT_RANGE flag as described in the
> > > +.BR fallocate (2)
> > > +manual page
> > 
> Hi Eric,
> > So, it looks like the fallocate(2) manpage will need an update as well.  :)
> Right, I am planning to send the manpage patch for insert range when merging 
> linus tree..

Best to have the man page with the rest of the code changes, that
way they all get reviewed at the same time. :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>