xfs
[Top] [All Lists]

Re: [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert ran

To: Namjae Jeon <linkinjeon@xxxxxxxxx>
Subject: Re: [PATCH v9 4/11] xfsprogs: xfs_io: add finsert command for insert range
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 6 Feb 2015 14:11:29 +1100
Cc: tytso@xxxxxxx, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, bfoster@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, a.sangwan@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150205234033.GW4251@dastard>
References: <1421853126-4505-1-git-send-email-linkinjeon@xxxxxxxxx> <1421853126-4505-5-git-send-email-linkinjeon@xxxxxxxxx> <20150205234033.GW4251@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
Hi Namjae,

On Fri, Feb 06, 2015 at 10:40:33AM +1100, Dave Chinner wrote:
> On Thu, Jan 22, 2015 at 12:11:59AM +0900, Namjae Jeon wrote:
> > From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > 
> > Add finsert command for fallocate FALLOC_FL_INSERT_RANGE flag.
> > 
> > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
> > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> 
> I've just pulled this patch into xfsprogs in preparation for getting
> this functionality fully reviewed and merged in the 3.21 kernel
> cycle.

xfs/293 3s ... - output mismatch (see 
/home/dave/src/xfstests-dev/results//xfs/293.out.bad)
    --- tests/xfs/293.out       2014-01-20 16:57:34.000000000 +1100
    +++ /home/dave/src/xfstests-dev/results//xfs/293.out.bad    2015-02-06 
12:21:47.000000000 +1100
    @@ -1,2 +1,3 @@
     QA output created by 293
     Silence is golden
    +finsert not documented in the xfs_io manpage
    .....

Can you send a patch that updates the xfs_io man page, please?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>