| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] xfs: struct xfs_sb is no longer tied to the on-disk format |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 4 Feb 2015 08:46:09 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150203213744.GA31631@xxxxxxxxxxxxx> |
| References: | <1422826983-29570-1-git-send-email-david@xxxxxxxxxxxxx> <1422826983-29570-2-git-send-email-david@xxxxxxxxxxxxx> <20150202084102.GA28121@xxxxxxxxxxxxx> <20150202193020.GJ6282@dastard> <20150203213744.GA31631@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 03, 2015 at 01:37:44PM -0800, Christoph Hellwig wrote: > On Tue, Feb 03, 2015 at 06:30:21AM +1100, Dave Chinner wrote: > > > I'd expect to move it close to stuct xfs_mount, and maybe even merge > > > it into that in the long run. > > > > I guess moving the structure there is fine, but we still want all > > the version functions to be shared with userspace, which then makes > > for an interesting set of dependencies. Any other ideas? > > Are they really worth the sharing? If they are worth it we'll > need somethign that can expect a xfs_sb/xfs_mount to be defined. I suppose we could stop sharing them - they change rarely enough and it's only a few lines of code for each new feature that would then need to be duplicated. Not a huge burden... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 2/5] xfs: use generic percpu counters for inode counter, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [RFC PATCH 0/5] xfs: use generic percpu counters for icsb, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/5] xfs: struct xfs_sb is no longer tied to the on-disk format, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 1/5] xfs: struct xfs_sb is no longer tied to the on-disk format, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |