xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: use generic percpu counters for inode counter

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: use generic percpu counters for inode counter
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 3 Feb 2015 13:38:32 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150202193344.GK6282@dastard>
References: <1422826983-29570-1-git-send-email-david@xxxxxxxxxxxxx> <1422826983-29570-3-git-send-email-david@xxxxxxxxxxxxx> <20150202164409.GA695@xxxxxxxxxxxxx> <20150202193344.GK6282@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Feb 03, 2015 at 06:33:44AM +1100, Dave Chinner wrote:
> > Why would the percpu counter not be initialized here?  Oh, I guess
> > this is for xfs_sb_verify().  But why can't xfs_mount_validate_sb simply
> > operate on the disk endian SB to avoid that whole issue?
> 
> Possibly. I'll look into it.

A simpler alternative would be to move them out of __xfs_sb_from_disk
into the one caller that needs these values.

<Prev in Thread] Current Thread [Next in Thread>