[Top] [All Lists]

Re: [PATCH 16/20] xfs: pass a 64-bit count argument to xfs_iomap_write_u

To: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Subject: Re: [PATCH 16/20] xfs: pass a 64-bit count argument to xfs_iomap_write_unwritten
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 3 Feb 2015 19:35:33 +0100
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150202194826.GG22301@xxxxxxxxxxxx>
References: <1421925006-24231-1-git-send-email-hch@xxxxxx> <1421925006-24231-17-git-send-email-hch@xxxxxx> <20150129205232.GB11064@xxxxxxxxxxxx> <20150202073024.GA9399@xxxxxx> <20150202192404.GI6282@dastard> <20150202194300.GN6282@dastard> <20150202194826.GG22301@xxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Feb 02, 2015 at 02:48:26PM -0500, J. Bruce Fields wrote:
> Previously: http://lkml.kernel.org/r/20150106175611.GA16413@xxxxxx
>       >       - any advice on testing?  Is there was some simple
>       >       virtual setup that would allow any loser with no special
>       >       hardware (e.g., me) to check whether they've broken the
>       >       block server?
>       Run two kvm VMs that share the same disk.  Create an XFS
>       filesystem on the MDS, and export it.  If the client has blkmapd
>       running (on Debian it needs to be started manually) it will use
>       pNFS for accessing the filesystem.  Verify that using the
>       per-operation counters in /proc/self/mounstats.  Repeat with
>       additional clients as nessecary.
>       Alternatively set up a simple iSCSI target using tgt or lio and
>       connect to it from multiple clients.
> Which sounds reasonable to me, but I haven't tried to incorporate this
> into my regression testing yet.

Additionally I can offer the following script to generate recalls,
which don't really happen during normal operation.  I don't
really know how to write a proper testcase that coordinates access
to the exported filesystem and nfs unless it runs locally on the same node,
though.  It would need some higher level, network aware test harness:

----- snip -----

set +x

# wait for grace period
touch /mnt/nfs1/foo

dd if=/dev/zero of=/mnt/nfs1/foo bs=128M count=32 conv=fdatasync oflag=direct &

sleep 2

echo "" > /mnt/test/foo && echo "recall done"

<Prev in Thread] Current Thread [Next in Thread>