xfs
[Top] [All Lists]

Re: [PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err()

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err()
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 2 Feb 2015 11:27:55 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <54CB2487.6040602@xxxxxxxxxxx>
References: <54CB2487.6040602@xxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jan 30, 2015 at 12:28:23AM -0600, Eric Sandeen wrote:
> Because this is usually the first question asked...
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---

Good idea.

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> 
> diff --git a/libxfs/util.c b/libxfs/util.c
> index 9504e33..6464a1b 100644
> --- a/libxfs/util.c
> +++ b/libxfs/util.c
> @@ -718,6 +718,7 @@ libxfs_fs_repair_cmn_err(int level, xfs_mount_t *mp, char 
> *fmt, ...)
>       va_start(ap, fmt);
>       vfprintf(stderr, fmt, ap);
>       fprintf(stderr, "  This is a bug.\n");
> +     fprintf(stderr, "%s version %s\n", progname, VERSION);
>       fprintf(stderr, "Please capture the filesystem metadata with "
>                       "xfs_metadump and\nreport it to xfs@xxxxxxxxxxxx\n");
>       va_end(ap);
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err(), Brian Foster <=