xfs
[Top] [All Lists]

Re: [PATCH 16/20] xfs: pass a 64-bit count argument to xfs_iomap_write_u

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 16/20] xfs: pass a 64-bit count argument to xfs_iomap_write_unwritten
From: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
Date: Thu, 29 Jan 2015 15:52:32 -0500
Cc: Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1421925006-24231-17-git-send-email-hch@xxxxxx>
References: <1421925006-24231-1-git-send-email-hch@xxxxxx> <1421925006-24231-17-git-send-email-hch@xxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Who can give us ACKs on these last five fs/xfs patches?  (And is it
going to cause trouble if they go in through the nfsd tree?)

--b.

On Thu, Jan 22, 2015 at 12:10:02PM +0100, Christoph Hellwig wrote:
> The code is already ready for it, and the pnfs layout commit code expects
> to be able to pass a larger than 32-bit argument.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  fs/xfs/xfs_iomap.c | 2 +-
>  fs/xfs/xfs_iomap.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index c980e2a..ccb1dd0 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -802,7 +802,7 @@ int
>  xfs_iomap_write_unwritten(
>       xfs_inode_t     *ip,
>       xfs_off_t       offset,
> -     size_t          count)
> +     xfs_off_t       count)
>  {
>       xfs_mount_t     *mp = ip->i_mount;
>       xfs_fileoff_t   offset_fsb;
> diff --git a/fs/xfs/xfs_iomap.h b/fs/xfs/xfs_iomap.h
> index 411fbb8..8688e66 100644
> --- a/fs/xfs/xfs_iomap.h
> +++ b/fs/xfs/xfs_iomap.h
> @@ -27,6 +27,6 @@ int xfs_iomap_write_delay(struct xfs_inode *, xfs_off_t, 
> size_t,
>                       struct xfs_bmbt_irec *);
>  int xfs_iomap_write_allocate(struct xfs_inode *, xfs_off_t,
>                       struct xfs_bmbt_irec *);
> -int xfs_iomap_write_unwritten(struct xfs_inode *, xfs_off_t, size_t);
> +int xfs_iomap_write_unwritten(struct xfs_inode *, xfs_off_t, xfs_off_t);
>  
>  #endif /* __XFS_IOMAP_H__*/
> -- 
> 1.9.1

<Prev in Thread] Current Thread [Next in Thread>