xfs
[Top] [All Lists]

Re: [PATCH] xfs:change kmem_free to use generic kvfree()

To: "Wang, Yalin" <Yalin.Wang@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs:change kmem_free to use generic kvfree()
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Thu, 29 Jan 2015 10:46:52 -0500
Cc: "'david@xxxxxxxxxxxxx'" <david@xxxxxxxxxxxxx>, "'xfs@xxxxxxxxxxx'" <xfs@xxxxxxxxxxx>, "'linux-kernel@xxxxxxxxxxxxxxx'" <linux-kernel@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <35FD53F367049845BC99AC72306C23D1044A02027DFF@xxxxxxxxxxxxxxxxxxxxxxx>
References: <35FD53F367049845BC99AC72306C23D1044A02027DFF@xxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Jan 28, 2015 at 02:08:47PM +0800, Wang, Yalin wrote:
> Change kmem_free to use kvfree() generic function,
> remove the duplicated code.
> 
> Signed-off-by: Yalin Wang <yalin.wang@xxxxxxxxxxxxxx>
> ---

Looks good...

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  fs/xfs/kmem.c | 10 ----------
>  fs/xfs/kmem.h |  5 ++++-
>  2 files changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
> index 53e95b2..a7a3a63 100644
> --- a/fs/xfs/kmem.c
> +++ b/fs/xfs/kmem.c
> @@ -91,16 +91,6 @@ kmem_zalloc_large(size_t size, xfs_km_flags_t flags)
>       return ptr;
>  }
>  
> -void
> -kmem_free(const void *ptr)
> -{
> -     if (!is_vmalloc_addr(ptr)) {
> -             kfree(ptr);
> -     } else {
> -             vfree(ptr);
> -     }
> -}
> -
>  void *
>  kmem_realloc(const void *ptr, size_t newsize, size_t oldsize,
>            xfs_km_flags_t flags)
> diff --git a/fs/xfs/kmem.h b/fs/xfs/kmem.h
> index 64db0e5..cc6b768 100644
> --- a/fs/xfs/kmem.h
> +++ b/fs/xfs/kmem.h
> @@ -63,7 +63,10 @@ kmem_flags_convert(xfs_km_flags_t flags)
>  extern void *kmem_alloc(size_t, xfs_km_flags_t);
>  extern void *kmem_zalloc_large(size_t size, xfs_km_flags_t);
>  extern void *kmem_realloc(const void *, size_t, size_t, xfs_km_flags_t);
> -extern void  kmem_free(const void *);
> +static inline void  kmem_free(const void *ptr)
> +{
> +     kvfree(ptr);
> +}
>  
>  
>  extern void *kmem_zalloc_greedy(size_t *, size_t, size_t);
> -- 
> 2.2.2
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>