| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC PATCH 4/6] xfs: take i_mmap_lock on extent manipulation operations |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 23 Jan 2015 08:32:41 +1100 |
| Cc: | xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20150122132307.GB25345@xxxxxxxxxxxxxxx> |
| References: | <1420669543-8093-1-git-send-email-david@xxxxxxxxxxxxx> <1420669543-8093-5-git-send-email-david@xxxxxxxxxxxxx> <20150122132307.GB25345@xxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 22, 2015 at 08:23:08AM -0500, Brian Foster wrote: > On Thu, Jan 08, 2015 at 09:25:41AM +1100, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index 8be5bb5..f491860 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -768,7 +768,7 @@ xfs_setattr_size( > > if (error) > > return error; > > > > - ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL)); > > + ASSERT(xfs_isilocked(ip, XFS_IOLOCK_EXCL|XFS_MMAPLOCK_EXCL)); > > Only debug code of course, but xfs_isilocked() doesn't appear to support > what is intended by this call (e.g., verification of multiple locks). Ah, right. Didn't think that one though properly. I'll fix it up. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [RFC PATCH 1/6] xfs: introduce mmap/truncate lock, Dave Chinner |
|---|---|
| Next by Date: | [PATCH 1/2] xfs_spaceman: XFS_IOC_FIEMAPFS ioctl replacing previous FS_IOC_FIEMAPFS, Dhruvesh Rathore |
| Previous by Thread: | Re: [RFC PATCH 4/6] xfs: take i_mmap_lock on extent manipulation operations, Brian Foster |
| Next by Thread: | [RFC PATCH 2/6] xfs: use i_mmaplock on read faults, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |