xfs
[Top] [All Lists]

Re: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 21 Jan 2015 23:23:20 +0100
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150121213826.GL16510@dastard>
References: <1421412471-4747-1-git-send-email-jack@xxxxxxx> <20150121213826.GL16510@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu 22-01-15 08:38:26, Dave Chinner wrote:
> On Fri, Jan 16, 2015 at 01:47:34PM +0100, Jan Kara wrote:
> >   Hello,
> > 
> >   this is another iteration of patches to unify VFS and XFS quota 
> > interfaces so
> > that XFS quotactls work for filesystems with VFS quotas and vice versa.  
> > This
> > is useful so that userspace doesn't have to care that much about which
> > filesystem it is using at least when using basic quota functionality. In
> > particular we should be able to reuse project quota tests in xfstests for 
> > ext4.
> > 
> > The patches are based on quota cleanup series [1] and XFS cleanup series [2]
> > I've sent previously and based on 3.19-rc4 + for-next branch of XFS tree.  I
> > could further split this series into per-quotactl series but frankly I don't
> > think it will help reviewers in any way (the patches in the current series 
> > are
> > already ordered by quotactl).
> 
> Hi Jan,
> 
> Do you have a this series in a git tree somewhere so it's easy to
> merge and test?
  I've pushed out the series to:
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git quota_interface

  BTW, I've already implemented suggestions by Christoph so it's not
exactly what was sent to the list (but very close). I'd also welcome your
opinion on usage of BBTOB() and BTOBB() macros in fs/quota/quota.c - to be
able to use them I have to move them out of fs/xfs/libxfs/xfs_fs.h to
somewhere in include/. Christoph doesn't like it much and would prefer
quota code just opencoded these macros. I don't really care but you two
should agree :)

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>