xfs
[Top] [All Lists]

[PATCH 0/3] xfs: buffer types need to be set

To: xfs@xxxxxxxxxxx
Subject: [PATCH 0/3] xfs: buffer types need to be set
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 21 Jan 2015 11:39:37 +1100
Cc: jack@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Hi Jan,

These three patches detect and fix the issues you reported with log
recovery finding buffers with a format type of zero. The type of
zero (XFS_BLFT_UNKNOWN_BUF) is only valid for buffers that have
been cancelled (i.e. invalidated or marked stale as they have been
freed), so the series adds asserts to ensure these conditions are
met during transaction commit. Hence we shouldn't ever get new code
that fails to set the buffer type getting through testing.

The last two patches fix the cases that running xfstests uncovered
where we don't set the buffer type appropriately. There may be more,
but doing this much made my head hurt and xfstests is clean, so it's
as much as I'm going to do right now. Can you test it and see if it
runs clean (with CONFIG_XFS_WARN=y or CONFIG_XFS_DEBUG=y) on your
test setup?

Cheers,

Dave.

<Prev in Thread] Current Thread [Next in Thread>