xfs
[Top] [All Lists]

Re: [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/17] ocfs2: Use generic helpers for quotaon and quotaoff
From: Jan Kara <jack@xxxxxxx>
Date: Tue, 20 Jan 2015 18:13:48 +0100
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150119090347.GE27474@xxxxxxxxxxxxx>
References: <1421412471-4747-1-git-send-email-jack@xxxxxxx> <1421412471-4747-6-git-send-email-jack@xxxxxxx> <20150119090347.GE27474@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon 19-01-15 01:03:47, Christoph Hellwig wrote:
> On Fri, Jan 16, 2015 at 01:47:39PM +0100, Jan Kara wrote:
> > Ocfs2 can just use the generic helpers provided by quota code for
> > turning quotas on and off when quota files are stored as system inodes.
> > The only difference is the feature test in ocfs2_quota_on() and that is
> > covered by dquot_quota_enable() checking whether usage tracking is
> > enabled (which can happen only if the filesystem has the quota feature
> > set).
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > ---
> >  fs/ocfs2/super.c | 32 +-------------------------------
> >  1 file changed, 1 insertion(+), 31 deletions(-)
> > 
> > diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> > index 83723179e1ec..706c71c2955d 100644
> > --- a/fs/ocfs2/super.c
> > +++ b/fs/ocfs2/super.c
> > @@ -1000,36 +1000,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super 
> > *osb)
> >     }
> >  }
> >  
> > -/* Handle quota on quotactl */
> > -static int ocfs2_quota_on(struct super_block *sb, int type, int format_id)
> > -{
> > -   unsigned int feature[OCFS2_MAXQUOTAS] = {
> > -                                   OCFS2_FEATURE_RO_COMPAT_USRQUOTA,
> > -                                   OCFS2_FEATURE_RO_COMPAT_GRPQUOTA};
> > -
> > -   if (!OCFS2_HAS_RO_COMPAT_FEATURE(sb, feature[type]))
> > -           return -EINVAL;
> 
> Where are we doing this feature check now?
  So OCFS2 (similarly as ext4 or xfs) has to enable quota accounting on
mount and at that point we test for the feature. Q_QUOTAON quotactl is
used just to turn on enforcement and at that point it makes no sense to
check for the feature (BTW, the changelog already explains this ;).

                                                                Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>