xfs
[Top] [All Lists]

[PATCH] xfs: remove incorrect error negation in attr_multi ioctl

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: remove incorrect error negation in attr_multi ioctl
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 20 Jan 2015 10:15:06 -0500
Delivered-to: xfs@xxxxxxxxxxx
xfs_compat_attrmulti_by_handle() calls memdup_user() which returns a
negative error code. The error code is negated by the caller and thus
incorrectly converted to a positive error code.

Remove the error negation such that the negative error is passed
correctly back up to userspace.

Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---
 fs/xfs/xfs_ioctl32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c
index ec67728..bfc7c7c 100644
--- a/fs/xfs/xfs_ioctl32.c
+++ b/fs/xfs/xfs_ioctl32.c
@@ -423,7 +423,7 @@ xfs_compat_attrmulti_by_handle(
 
        ops = memdup_user(compat_ptr(am_hreq.ops), size);
        if (IS_ERR(ops)) {
-               error = -PTR_ERR(ops);
+               error = PTR_ERR(ops);
                goto out_dput;
        }
 
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: remove incorrect error negation in attr_multi ioctl, Brian Foster <=