[Top] [All Lists]

Re: [PATCH 12/17] xfs: Convert to using ->get_state callback

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 12/17] xfs: Convert to using ->get_state callback
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 01:38:10 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1421412471-4747-13-git-send-email-jack@xxxxxxx>
References: <1421412471-4747-1-git-send-email-jack@xxxxxxx> <1421412471-4747-13-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> +static void xfs_qm_fill_state(struct qc_type_state *tstate,

Normal xfs style would be to keep the "static void " on a separate line,
as well as the arguments, e.g.

static void
        struct qc_type_state    *tstate,

> +                           struct xfs_mount *mp,
> +                           struct xfs_inode *ip,
> +                           xfs_ino_t ino)

No need to pass mp, as it can be derived as ip->i_mount.

Btw, I think this code should move into xfs_quotaops.c now
that it ties into the Linux quota interface, and xfs_qm_scall_getstate
should be folded into xfs_fs_get_quota_state.

<Prev in Thread] Current Thread [Next in Thread>