Re: [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing

To:	Jan Kara <jack@xxxxxxx>
Subject:	Re: [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 19 Jan 2015 01:09:14 -0800
Cc:	linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1421412471-4747-10-git-send-email-jack@xxxxxxx>
References:	<1421412471-4747-1-git-send-email-jack@xxxxxxx> <1421412471-4747-10-git-send-email-jack@xxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Fri, Jan 16, 2015 at 01:47:43PM +0100, Jan Kara wrote:
> Call ->quota_sync method from Q_XQUOTASYNC for better userspace
> compatibility.

Q_XQUOTASYNC never did the equivalent to ->quota_sync, but rather was
the equivalent to sys_syncfs which also happens to write out quotas.

Unless you have a really strong reason for wiring it up, I'd rather keep
it as-is.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff, (continued) [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff, Jan Kara Re: [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff, Christoph Hellwig [PATCH 03/17] quota: Add ->quota_{enable,disable} callbacks for VFS quotas, Jan Kara Re: [PATCH 03/17] quota: Add ->quota_{enable,disable} callbacks for VFS quotas, Christoph Hellwig Re: [PATCH 03/17] quota: Add ->quota_{enable,disable} callbacks for VFS quotas, Jan Kara [PATCH 01/17] quota: Split ->set_xstate callback into two, Jan Kara Re: [PATCH 01/17] quota: Split ->set_xstate callback into two, Christoph Hellwig [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks, Jan Kara Re: [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks, Christoph Hellwig [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing, Jan Kara Re: [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing, Christoph Hellwig <= Re: [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing, Jan Kara [PATCH 13/17] gfs2: Convert to using ->get_state callback, Jan Kara [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state, Jan Kara Re: [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state, Christoph Hellwig [PATCH 12/17] xfs: Convert to using ->get_state callback, Jan Kara Re: [PATCH 12/17] xfs: Convert to using ->get_state callback, Christoph Hellwig Re: [PATCH 12/17] xfs: Convert to using ->get_state callback, Jan Kara [PATCH 08/17] quota: Store maximum space limit in bytes, Jan Kara Re: [PATCH 08/17] quota: Store maximum space limit in bytes, Christoph Hellwig [PATCH 16/17] xfs: Add support for Q_SETINFO, Jan Kara

Previous by Date:	Re: [PATCH 08/17] quota: Store maximum space limit in bytes, Christoph Hellwig
Next by Date:	Re: [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info, Christoph Hellwig
Previous by Thread:	[PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing, Jan Kara
Next by Thread:	Re: [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing, Jan Kara
Indexes:	[Date] [Thread] [Top] [All Lists]