xfs
[Top] [All Lists]

Re: [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use b

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 01:07:20 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1421412471-4747-8-git-send-email-jack@xxxxxxx>
References: <1421412471-4747-1-git-send-email-jack@xxxxxxx> <1421412471-4747-8-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> index 18dc721ca19f..f718ba1f2ccb 100644
> --- a/fs/xfs/libxfs/xfs_fs.h
> +++ b/fs/xfs/libxfs/xfs_fs.h
> @@ -559,18 +559,4 @@ typedef struct xfs_swapext
>  /*   XFS_IOC_GETFSUUID ---------- deprecated 140      */
>  
>  
> -#ifndef HAVE_BBMACROS
> -/*
> - * Block I/O parameterization.       A basic block (BB) is the lowest size of
> - * filesystem allocation, and must equal 512.  Length units given to bio
> - * routines are in BB's.
> - */
> -#define BBSHIFT              9
> -#define BBSIZE               (1<<BBSHIFT)
> -#define BBMASK               (BBSIZE-1)
> -#define BTOBB(bytes) (((__u64)(bytes) + BBSIZE - 1) >> BBSHIFT)
> -#define BTOBBT(bytes)        ((__u64)(bytes) >> BBSHIFT)
> -#define BBTOB(bbs)   ((bbs) << BBSHIFT)
> -#endif

Please don't move these defintions around and just opencode them in
the quota code.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>