[Top] [All Lists]

Re: [PATCH 01/17] quota: Split ->set_xstate callback into two

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 01/17] quota: Split ->set_xstate callback into two
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2015 01:00:35 -0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1421412471-4747-2-git-send-email-jack@xxxxxxx>
References: <1421412471-4747-1-git-send-email-jack@xxxxxxx> <1421412471-4747-2-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jan 16, 2015 at 01:47:35PM +0100, Jan Kara wrote:
> Split ->set_xstate callback into two callbacks - one for turning quotas
> on (->quota_enable) and one for turning quotas off (->quota_disable). That
> way we don't have to pass quotactl command into the callback which seems
> cleaner.
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>