xfs
[Top] [All Lists]

RE: [PATCH v8 2/11] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocat

To: 'Brian Foster' <bfoster@xxxxxxxxxx>, 'Namjae Jeon' <linkinjeon@xxxxxxxxx>
Subject: RE: [PATCH v8 2/11] xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate
From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
Date: Fri, 16 Jan 2015 16:26:36 +0900
Cc: david@xxxxxxxxxxxxx, tytso@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, a.sangwan@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dlp-filter: Pass
In-reply-to: <20150115122906.GC18876@xxxxxxxxxxxxxxx>
References: <1421165126-3585-1-git-send-email-linkinjeon@xxxxxxxxx> <1421165126-3585-3-git-send-email-linkinjeon@xxxxxxxxx> <20150115122906.GC18876@xxxxxxxxxxxxxxx>
Thread-index: AQI8HFfblg/gPWIGszLKUjAczsKp1gHJln/+AbRh1nebzpFi4A==
> On Wed, Jan 14, 2015 at 01:05:17AM +0900, Namjae Jeon wrote:
> > From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> >
> > This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
> >
> > 1) Make sure that both offset and len are block size aligned.
> > 2) Update the i_size of inode by len bytes.
> > 3) Compute the file's logical block number against offset. If the computed
> >    block number is not the starting block of the extent, split the extent
> >    such that the block number is the starting block of the extent.
> > 4) Shift all the extents which are lying bewteen [offset, last allocated 
> > extent]
> >    towards right by len bytes. This step will make a hole of len bytes
> >    at offset.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > Signed-off-by: Ashish Sangwan <a.sangwan@xxxxxxxxxxx>
> > Cc: Brian Foster<bfoster@xxxxxxxxxx>
> > ---
> 
> Fixes look good (I assume nothing else changed between the few nits
> called out in v7) and survives overnight fsstress and fsx testing
> without any explosions:
Yes, I am also running test for long time, If there is any issue, will share.
Thanks for your review and help :)
> 
> Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> 

<Prev in Thread] Current Thread [Next in Thread>