xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: Remove useless test

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 1/3] xfs: Remove useless test
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Thu, 15 Jan 2015 08:27:54 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1421317085-14350-2-git-send-email-jack@xxxxxxx>
References: <1421317085-14350-1-git-send-email-jack@xxxxxxx> <1421317085-14350-2-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Jan 15, 2015 at 11:18:03AM +0100, Jan Kara wrote:
> Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  fs/xfs/xfs_quotaops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> index 7542bbeca6a1..8fcd20dbf89a 100644
> --- a/fs/xfs/xfs_quotaops.c
> +++ b/fs/xfs/xfs_quotaops.c
> @@ -75,7 +75,7 @@ xfs_fs_set_xstate(
>  
>       if (sb->s_flags & MS_RDONLY)
>               return -EROFS;
> -     if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
> +     if (!XFS_IS_QUOTA_RUNNING(mp))
>               return -ENOSYS;
>  
>       if (uflags & FS_QUOTA_UDQ_ACCT)
> -- 
> 2.1.2
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>