[Top] [All Lists]

Re: [PATCH 17/18] xfs: implement pnfs export operations

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 17/18] xfs: implement pnfs export operations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 12 Jan 2015 14:04:01 +1100
Cc: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150109114159.GA25728@xxxxxx>
References: <1420561721-9150-1-git-send-email-hch@xxxxxx> <1420561721-9150-18-git-send-email-hch@xxxxxx> <20150107002434.GG31508@dastard> <20150107104010.GD28783@xxxxxx> <20150107211140.GC25000@dastard> <20150108124327.GA15222@xxxxxx> <20150108210405.GG25000@dastard> <20150109114159.GA25728@xxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jan 09, 2015 at 12:41:59PM +0100, Christoph Hellwig wrote:
> On Fri, Jan 09, 2015 at 08:04:05AM +1100, Dave Chinner wrote:
> > > If the client sends the opaqueue device ID that contains the generation
> > > after the grow to a server that had crashed / restarted the server
> > > will reject it as the server starts at zero.  The causes the client
> > > to get a new, valid device ID from the server.
> > 
> > But if the server fs has a generation number of zero when it
> > crashes, how does the client tell that it needs a new device ID from
> > the server?
> >
> > > Unlike the NFS file hadles which are persistent the device IDs are 
> > > volatile
> > > handles that can go away (and have really horrible life time rules..).
> > 
> > Right. How the clients detect that "going away" when the device
> > generation is zero both before and after a server crash is the
> > question I'm asking....
> The server tells the client by rejecting the operation using the
> device ID.

Ok, so:

client                          server

get layout
dev id == 0
                                gen++ (=1)
                                gen = 0 (initialised after boot)

commit layout
dev id == 0
                                server executes op, even though
                                device has changed....

What prevents this? Shouldn't the server be rejecting the commit
layout operation as there was a grow operation between the client


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>