[Top] [All Lists]

Re: [PATCH 09/18] nfsd: implement pNFS operations

To: Jeff Layton <jeff.layton@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 09/18] nfsd: implement pNFS operations
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 9 Jan 2015 11:05:51 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150108164851.03b64e16@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1420561721-9150-1-git-send-email-hch@xxxxxx> <1420561721-9150-10-git-send-email-hch@xxxxxx> <20150108164851.03b64e16@xxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Jan 08, 2015 at 04:48:51PM -0800, Jeff Layton wrote:
> > +   nfsd4_return_all_file_layouts(stp->st_stateowner->so_client,
> > +                                 stp->st_stid.sc_file);
> > +
> Shouldn't the above be conditional on whether the lg_roc was true?

There is no support for non-lg_roc layouts at the moment.

In general I've avoided adding code that isn't used, as they can't
be tested and thus most likely won't work.

<Prev in Thread] Current Thread [Next in Thread>