[Top] [All Lists]

Re: [PATCH 4/4] xfs: move xfs_bmap_finish prototype

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: move xfs_bmap_finish prototype
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2015 10:15:03 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150108124627.GD3424@xxxxxxxxxxxxx>
References: <1420666983-7275-1-git-send-email-david@xxxxxxxxxxxxx> <1420666983-7275-5-git-send-email-david@xxxxxxxxxxxxx> <20150108124627.GD3424@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jan 08, 2015 at 04:46:27AM -0800, Christoph Hellwig wrote:
> On Thu, Jan 08, 2015 at 08:43:03AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > This function is used libxfs code, but is implemented separately in
> > userspace. Move the function prototype to xfs_bmap.h so that the
> > prototype is shared even if the implementations aren't.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Does this help you a lot?  Seems a little on the fringe to me, but
> if it helps I'm fine with it:

It's just another random difference. We define the other bmap
freelist prototypes in xfs_bmap.h (e.g. xfs_bmap_cancel) because
there is libxfs code that uses them, even though the implementations
are not in the shared libxfs code. So while it's a small change, it
makes everything consistent and makes the diff between kernel and
user space just a little smaller.

There's likely to be a few more small changes like this as I work
through all the remaining differences inthe code bases....

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>