xfs
[Top] [All Lists]

Re: Disconnected inodes after test xfs/261

To: Jan Kara <jack@xxxxxxx>
Subject: Re: Disconnected inodes after test xfs/261
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 18 Dec 2014 08:02:26 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141217193535.GA8231@xxxxxxxxxxxxx>
References: <20141217193535.GA8231@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 17, 2014 at 08:35:35PM +0100, Jan Kara wrote:
>   Hello,
> 
>   in my test KVM with today's Linus' kernel I'm getting xfs_repair
> complaint about disconnected inodes after the test xfs/261 finishes
> (with success). xfs_repair output is like:
> xfs_repair -n /dev/vdb2
> Phase 1 - find and verify superblock...
> Phase 2 - using internal log
>         - scan filesystem freespace and inode maps...
>         - found root inode chunk
> Phase 3 - for each AG...
>         - scan (but don't clear) agi unlinked lists...
>         - process known inodes and perform inode discovery...
>         - agno = 0
>         - agno = 1
>         - agno = 2
>         - agno = 3
>         - process newly discovered inodes...
> Phase 4 - check for duplicate blocks...
>         - setting up duplicate extent list...
>         - check for inodes claiming duplicate blocks...
>         - agno = 0
>         - agno = 1
>         - agno = 2
>         - agno = 3
> No modify flag set, skipping phase 5
> Phase 6 - check inode connectivity...
>         - traversing filesystem ...
>         - traversal finished ...
>         - moving disconnected inodes to lost+found ...
> disconnected inode 132, would move to lost+found
> disconnected inode 133, would move to lost+found
> Phase 7 - verify link counts...
> No modify flag set, skipping filesystem flush and exiting.
> ---
> Given how trivial test xfs/261 is, it seems like created private mtab files
> that also get unlinked don't get added to AGI unlinked list before umount.
> I didn't have a detailed look whether that's possible or not and probably
> won't get to it before Christmas. So I'm sending this just in case someone
> more knowledgeable has ideas earlier...

I don't see that here. If you mount/unmount the filesystem, does the
warning go away? i.e. xfs_repair -n ignores the contents of
the log, so if the unlinked list transactions are in the log then
log recovery will make everything good again.

That said, if unmount is not leaving the log clean, then we've still
got an issue we need to get to the bottom of.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>