xfs
[Top] [All Lists]

Re: [PATCH] xfs: remove extra newlines from xfs messages

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: remove extra newlines from xfs messages
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 15 Dec 2014 10:24:53 -0800
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <548B6E07.8080302@xxxxxxxxxx>
References: <548B6E07.8080302@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Dec 12, 2014 at 04:36:55PM -0600, Eric Sandeen wrote:
> xfs_warn() and friends add a newline by default, but some
> messages add another one.  
> 
> Particularly for the failing write message below, this can
> waste a lot of console real estate!
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>