| To: | Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask() |
| From: | Jan Kara <jack@xxxxxxx> |
| Date: | Thu, 4 Dec 2014 19:34:16 +0100 |
| Cc: | Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20141204143708.GM29748@xxxxxxxxxxxxxxxxxx> |
| References: | <1417699659-14284-1-git-send-email-jack@xxxxxxx> <1417699659-14284-3-git-send-email-jack@xxxxxxx> <20141204143708.GM29748@xxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu 04-12-14 14:37:09, Al Viro wrote:
> On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote:
> > WARN_ON in inode_set_mask() warns if we don't clear all bits we are
> > setting instead of reverse - warning when caller requests setting and
> > clearing of the same bit.
>
> WTF? 'mask' is "all bits we are asked to modify", 'flags' - "the values to
> put into those bits". Have you even looked at the callers, let alone
> tested it?
Sorry, I misunderstood how the function is supposed to work. Discard this
patch please.
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs: initialize log buf I/O completion wq on log alloc, Brian Foster |
|---|---|
| Next by Date: | Re: [PATCH] xfs: fix behaviour of XFS_IOC_FSSETXATTR on directories, Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask(), Al Viro |
| Next by Thread: | [PATCH] xfs: initialize log buf I/O completion wq on log alloc, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |