[Top] [All Lists]

Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask()

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask()
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Dec 2014 14:37:09 +0000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1417699659-14284-3-git-send-email-jack@xxxxxxx>
References: <1417699659-14284-1-git-send-email-jack@xxxxxxx> <1417699659-14284-3-git-send-email-jack@xxxxxxx>
Sender: Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 04, 2014 at 02:27:36PM +0100, Jan Kara wrote:
> WARN_ON in inode_set_mask() warns if we don't clear all bits we are
> setting instead of reverse - warning when caller requests setting and
> clearing of the same bit.

WTF?  'mask' is "all bits we are asked to modify", 'flags' - "the values to
put into those bits".  Have you even looked at the callers, let alone
tested it?

<Prev in Thread] Current Thread [Next in Thread>