[Top] [All Lists]

Re: [PATCH] xfs: fix set-but-unused warnings

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix set-but-unused warnings
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2014 09:05:03 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141202092310.GA25767@xxxxxxxxxxxxx>
References: <1417489741-11223-1-git-send-email-david@xxxxxxxxxxxxx> <20141202092310.GA25767@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 02, 2014 at 01:23:10AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 02, 2014 at 02:09:01PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The kernel compile doesn't turn on these checks by default, so it's
> > only when I do a kernel-user sync that I find that there are lots of
> > compiler warnings waiting to be fixed. Fix up these set-but-unused
> > warnings.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Looks good.  Maybe we should enable those warnings for fs/xfs?

I now have a local patch (-Werror -Wunused-but-set-variable) that
catches these during my for-next integration testing workflow, so
I should catch them (and other errors) during review....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>