xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: move type conversion functions to xfs_dir.h
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2014 08:52:08 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20141202113626.GA30327@xxxxxxxxxxxxx>
References: <1417475883-21881-1-git-send-email-david@xxxxxxxxxxxxx> <1417475883-21881-3-git-send-email-david@xxxxxxxxxxxxx> <20141202113626.GA30327@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 02, 2014 at 03:36:26AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 02, 2014 at 10:18:03AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > These are currently considered private to libxfs, but they are
> > widely used by the userspace code to decode, walk and check
> > directory structures. Hence they really form part of the external
> > API and as such need to bemoved to xfs_dir2.h.
> 
> Lokos good, but why do we need the additional includes in various files?

Because the conversion functions have a dependency on the struct
xfs_da_geometry definition in xfs_da_btree.h. xfs_dir2_priv.h had
that dependency, but xfs_dir2.h didn't. Now the conversion functions
have been moved, that dependency moves as well...

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Did you mean Reviewed-by? :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>