[Top] [All Lists]

Re: [PATCH-v5 1/5] vfs: add support for a lazytime mount option

To: Andreas Dilger <adilger@xxxxxxxxx>
Subject: Re: [PATCH-v5 1/5] vfs: add support for a lazytime mount option
From: Theodore Ts'o <tytso@xxxxxxx>
Date: Tue, 2 Dec 2014 16:01:19 -0500
Cc: Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=QMXOqX2kBPVKUGcLGQC0mzTt021/qBjzu1DahZ2Lxv0=; b=r/cvzWutHPT6xU9NGkEdhlwcif/Z0BemYK2KSUg/9UugLT2L9A+we3swTzu8PnW8J1QToekEEqK2MTMRcsZ9Oi/CENXkDYJzPbtyAIFChs/B3bMiCXUkdPoagKtdwN+tZrSJCUuFCLgjlG5jT4XU3S5MxY4q8lz4k5FMm0uR/PI=;
In-reply-to: <0CAF91FD-F713-4E98-8967-9CA0390CA784@xxxxxxxxx>
References: <1417154411-5367-1-git-send-email-tytso@xxxxxxx> <1417154411-5367-2-git-send-email-tytso@xxxxxxx> <20141128172323.GD738@xxxxxxxxxxxxx> <20141128181421.GA19461@xxxxxxxxxx> <20141202125820.GE9092@xxxxxxxxxxxxx> <547DFD24.9070805@xxxxxxxxxxxxx> <20141202192337.GA13618@xxxxxxxxx> <0CAF91FD-F713-4E98-8967-9CA0390CA784@xxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Dec 02, 2014 at 01:37:27PM -0700, Andreas Dilger wrote:
> One thing that comes to mind is touch/utimes()/utimensat().  Those
> should definitely not result in timestamps being kept only in memory
> for 24h, since the whole point of those calls is to update the times.
> It makes sense for these APIs to dirty the inode for proper writeout.

Not a problem.  Touch/utimes* go through notify_change() and
->setattr, so they won't go through the I_DIRTY_TIME code path.

                                        - Ted

<Prev in Thread] Current Thread [Next in Thread>