[Top] [All Lists]

Re: [PATCH] xfs: fix set-but-unused warnings

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix set-but-unused warnings
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 2 Dec 2014 01:23:10 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1417489741-11223-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1417489741-11223-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Dec 02, 2014 at 02:09:01PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> The kernel compile doesn't turn on these checks by default, so it's
> only when I do a kernel-user sync that I find that there are lots of
> compiler warnings waiting to be fixed. Fix up these set-but-unused
> warnings.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.  Maybe we should enable those warnings for fs/xfs?

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>